"Added Dockerfile to dockerized the website" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
| @@ -0,0 +1,7 @@ | |||
| FROM ubuntu | |||
| RUN apt update -y | |||
| LABEL maintainer="Rohan Rustagi" | |||
There was a problem hiding this comment.
We can't take your name as maintainer!
Dockerfile
Outdated
| @@ -0,0 +1,7 @@ | |||
| FROM ubuntu | |||
There was a problem hiding this comment.
Cant we use alpine image?
There was a problem hiding this comment.
yes we can, but the image is already very optimised and some dependencies doesn't work for alpine image. I don't have any issue using that, If you want I can use that.
Dockerfile
Outdated
| LABEL maintainer="Rohan Rustagi" | ||
| RUN apt install nginx -y | ||
| COPY . /var/www/html | ||
| EXPOSE 80 |
There was a problem hiding this comment.
We will probably have to expose 443(https) too
|
Hi @chandansgowda @ghpranav @Ramiz1336 @ShivamMenda , I have modified the Dockerfile as per the above comments. Also documented the README.md file and added nginx.conf to securely expose port 443(https). Please Review & Approve :) Thanks, |
|
@chandansgowda, can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI @ghpranav @chandansgowda @Ramiz1336 @ShivamMenda @Sayed-Afnan-Khazi ,
I have created Dockerfile to Containerised the website which will help the website to get easily deploy on linux servers. I am actively participating in HacktoberFest 2023 :)
Please Review & Approve.
Thanks,
Rohan