Skip to content

Commit

Permalink
Merge pull request brownplt#1757 from ds26gte/js-mulreg
Browse files Browse the repository at this point in the history
minor improvements to multipe-regression() part II
  • Loading branch information
ds26gte authored Aug 27, 2024
2 parents 3b60b9c + af4f716 commit 0620ea8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion src/arr/trove/statistics.arr
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ fun matrix-based-multiple-regression(x_s_s :: List<List<Number>>, y_s :: List<Nu
B_pred_fn
end

fun multiple-regression(x_s_s :: List<List<Number>>, y_s :: List<Number>) -> (Any -> Number):
fun multiple-regression(x_s_s :: List<List<Number>>, y_s :: List<Number>) -> (List<Number> -> Number):
doc: "returns a predictor function given a list of list of independent inputs and the correspoinding list of outputs"
MR.multiple-regression(x_s_s, y_s)
end
Expand Down
2 changes: 0 additions & 2 deletions src/js/trove/multiple-regression.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,7 @@
runtime.checkNumber(x);
result += runtime.num_to_fixnum(x) * B[i+1][0]
}
console.log('predr result before return', result);
return runtime.num_to_roughnum(result);
// return runtime.makeNumber(result);
}
return runtime.makeFunction(Bfunc, "predictor");
}
Expand Down

0 comments on commit 0620ea8

Please sign in to comment.