[WIP] Add support for Rails::Engine #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favour of #49
Don't mind me yet, just looking what's what π
Adding dry-rails to monolith Rails app works like a charm, thanks for all the work πββοΈ
However, it's not so great when used with Engines
I think each Engine should define its own Container, otherwise we're loosing whole namespace isolation that Engines provide
π₯³