#6628: Added a command to remove a deploy hook from the list of deployed hooks in the site State #6280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harivansh0
changed the title
harivansh0
changed the title
MurzNN
reviewed
May 12, 2025
| }); | ||
|
|
||
| // Update the deployed hook list. | ||
| \Drupal::service('keyvalue')->get('deploy_hook')->set('existing_updates', $update_functions); |
There was a problem hiding this comment.
We should have this service available as $this->keyValue.
There was a problem hiding this comment.
Hi @MurzNN
The DeployHookCommands class does not have a keyValue property. Although the getRegistry() function injects the service, the class extends UpdateRegistry, which defines keyValue as a protected property. Since it's protected and not accessible directly in the subclass, we cannot use it, without modifying the drupal core UpdateRegistry or use refelection.
Or I could using autowire to inject
#[Autowire(service: 'keyvalue')] protected KeyValueFactoryInterface $keyValueFactory,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.