Add some minor attributes and classes into stubs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add parents property to mutablebase
…ox#143) The relationship(passive_deletes=...) can be either a boolean or a string: https://docs.sqlalchemy.org/en/13/orm/relationship_api.html#sqlalchemy.orm.relationship.params.passive_deletes
See: https://docs.sqlalchemy.org/en/13/orm/session_api.html#sqlalchemy.orm.session.Session.merge Quote: ... The state of each attribute on the source instance is then copied to the target instance. The resulting target instance is then returned by the method ...
Co-authored-by: Keigo Kawamura <[email protected]>
Currently, the plugin types relationships with uselist as Iterable[X], but these relationships actually expose a list with list semantics, including .append(), assignments, etc. This PR updates the plugin to type those relationships with List[X] instead of Iterable[X]. Ref: https://docs.sqlalchemy.org/en/13/orm/relationship_api.html#sqlalchemy.orm.relationship.params.uselist Ref of usage with assignment: https://docs.sqlalchemy.org/en/13/orm/tutorial.html#working-with-related-objects Ref of usage with append: https://docs.sqlalchemy.org/en/13/orm/tutorial.html#building-a-many-to-many-relationship Note: I'm by no means expert in mypy internals and its plugins, I'm not 100% sure the usage of ctx.api.named_generic_type('builtins.list', [new_arg]) is correct here, but I see that seems to be how it's used by mypy: https://github.com/python/mypy/blob/master/mypy/plugins/ctypes.py#L158
sqlalchemy/sqlalchemy#5043 added support for CTE prefix clauses in PostgreSQL 12. This PR fixes the dreadful `"CTE" has no attribute "prefix_with"` error for me.
This makes the stubs with mypy version 0.800 (to be released soon). Co-authored-by: Ivan Levkivskyi <[email protected]>
Co-authored-by: Keigo Kawamura <[email protected]>
Co-authored-by: Ivan Levkivskyi <[email protected]>
Co-authored-by: Ivan Levkivskyi <[email protected]>
Co-authored-by: Ivan Levkivskyi <[email protected]>
add methods to load
add pool lesser known members
|
Boryslav Larin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.