Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15 #49

Merged
merged 1 commit into from
Jun 22, 2018
Merged

fix #15 #49

merged 1 commit into from
Jun 22, 2018

Conversation

naftalmm
Copy link
Contributor

Worked for me. Tested on Xubuntu 16.04.

@nipunn1313
Copy link
Contributor

Hi - thanks for the contribution.

Do you know if this will cause a regression on any of the other supported setups (eg Ubuntu, Fedora)? Is dbus-launch always available?

Thanks
--Nipunn

@nipunn1313
Copy link
Contributor

Can you make sure to sign the CLA as well
thanks!
https://opensource.dropbox.com/cla/

@naftalmm
Copy link
Contributor Author

naftalmm commented Jun 20, 2018

Ok, I`ve signed CLA.

Is dbus-launch always available?

According to https://pkgs.org it should by present in majority of popular Linux distributives including Ubuntu & Fedora (or at least it's available in their repos), so it's highly unlikely, that it will cause a regression for this distributives.
Moreover, maybe it will even fix the same bug for Ubuntu (#38).

@nipunn1313
Copy link
Contributor

Ok sounds good! Thank you.
CC @samertm for heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants