Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying multiple catalogs via a table arg #432

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

laserkaplan
Copy link

@laserkaplan laserkaplan commented Mar 11, 2022

Basically the same as #246 but with a test added to showcase new functionality and a couple of fixes to resolve other bugs.

Many thanks to AlexandreOuellet for the original implementation!

@laserkaplan laserkaplan marked this pull request as draft March 11, 2022 17:27
@laserkaplan laserkaplan changed the title Alex changes Add support for querying multiple catalogs via a table arg Mar 11, 2022
@laserkaplan laserkaplan marked this pull request as ready for review March 11, 2022 19:40
@laserkaplan laserkaplan marked this pull request as draft March 11, 2022 19:41
@laserkaplan laserkaplan marked this pull request as ready for review March 11, 2022 19:42
@laserkaplan
Copy link
Author

@bkyryliuk I'm hoping that you are still active enough to see this :)
I have added a simple test to show the new functionality here. Please let me know if you would like to see anything else. It would be really great to finally get this into a release!

@AlexandreOuellet
Copy link

Thanks for the mention!

I'll try to reopen, update and correct my PR to pyhive so that it eventually gets in officially.

@laserkaplan laserkaplan mentioned this pull request Mar 24, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ AlexandreOuellet
✅ VinceDPM
✅ laserkaplan
❌ Aleandre Ouellet


Aleandre Ouellet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants