Skip to content

Conversation

ilang-flytrex
Copy link

  1. Increment the version to 1.2.29
  2. Add Load/Store buttons to store/load the table logs
  3. Add .vscode configurations

2. Add Load/Store buttons to store/load the table logs
Copy link
Contributor

@joshanne joshanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes because this should work for linux/windows/macos users alike. It's unclear that it will in this current state.

I've never pushed my launch.json, but the configuration I use is:

        {
            "name": "Python Debugger: DroneCAN GUI Tool",
            "type": "debugpy",
            "request": "launch",
            "program": "${workspaceFolder}/bin/dronecan_gui_tool",
            "cwd": "${workspaceFolder}/dronecan_gui_tool",
            "console": "integratedTerminal",
            "justMyCode": true,
            "args": [
                "--debug"
            ]
        }

"program": "${workspaceFolder}/bin/dronecan_gui_tool",
"console": "integratedTerminal",
"cwd": "${workspaceFolder}",
"python": "${workspaceFolder}/.venv/Scripts/python.exe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be specific to windows - if you're using vscode to launch it, it should be up to vscode to provide the environment you're using.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...The reason I wanted to add this was to simplify it for the programmer. It took me several iterations until I made it run. I come from the bare metal embedded world, and usually when you have a project then you also add the IDE configuration files (there can be more than one), so anyone can just run it without any complications. I'll remove it

}
},
{
"name": "Debug DroneCAN GUI Tool (Module)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to achieve by executing the main module?

With debug enabled, this simply outputs all the dsdl parser information as it is processed at startup. There is no usable application context run.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are left overs from my attempts to make it run. I'll remove it

#
#
__version__ = 1, 2, 28
__version__ = 1, 2, 29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically, the version isn't bumped until the immediately before the release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

2. Update .gitignore file to ignore virtual environments and vscode files
3. Restore the previous version to 1.2.28
@ilang-flytrex ilang-flytrex requested a review from joshanne August 6, 2025 08:28
@ilang-flytrex
Copy link
Author

@joshanne ,can you tell me where I can find instructions to how to distribute my code? I tried creating a task in vscode that does it (in windows). I was able to make it work, but for some reason when I start the Jupyter console it appears empty and It's not interactive. I would expect the repo to contain at least a .sh script for performing the distribution.

@joshanne
Copy link
Contributor

joshanne commented Aug 6, 2025

can you tell me where I can find instructions to how to distribute my code?

Do you mean distributing the installer to install your version of the tool? Windows? or Linux?

README.md points you to winbuild.bat which is the windows build tool which generates you an MSI at the end. Looks like you might need to update it to ensure your python executable is on the path, but it looks like it should be as simple as running winbuild.bat from the root directory of the repository.

On linux, judging by the github build tasks, you should be able to run the following to generate a wheel file for distribution. The wheel file will be in the dist folder.

python -m pip install --upgrade pip
pip install build
python -m pip install -U flake8 pytest wheel
python -m pip install -U .
python -m build

As for the interactive console not working, I'm unsure - I've not run into that problem. Whenever I launch the program, it seems to work as I expect.

@joshanne
Copy link
Contributor

joshanne commented Aug 6, 2025

Windows?

Other thing to note is winbuild.bat says:

rem NOTE: you need visual studio installed, with the C++ build tools

So make sure you have visual studio build tools installed, otherwise you can't build the msi file.

@ilang-flytrex
Copy link
Author

@joshanne ,I was sure that winbuild.bat is for building, not creating an msi file, but as you mentioned, it was written in the README file. Thanks a lot. I tried it and it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants