-
Notifications
You must be signed in to change notification settings - Fork 45
Load store logs #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Load store logs #95
Conversation
ilang-flytrex
commented
Jul 29, 2025
- Increment the version to 1.2.29
- Add Load/Store buttons to store/load the table logs
- Add .vscode configurations
2. Add Load/Store buttons to store/load the table logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting changes because this should work for linux/windows/macos users alike. It's unclear that it will in this current state.
I've never pushed my launch.json
, but the configuration I use is:
{
"name": "Python Debugger: DroneCAN GUI Tool",
"type": "debugpy",
"request": "launch",
"program": "${workspaceFolder}/bin/dronecan_gui_tool",
"cwd": "${workspaceFolder}/dronecan_gui_tool",
"console": "integratedTerminal",
"justMyCode": true,
"args": [
"--debug"
]
}
.vscode/launch.json
Outdated
"program": "${workspaceFolder}/bin/dronecan_gui_tool", | ||
"console": "integratedTerminal", | ||
"cwd": "${workspaceFolder}", | ||
"python": "${workspaceFolder}/.venv/Scripts/python.exe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be specific to windows - if you're using vscode to launch it, it should be up to vscode to provide the environment you're using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure...The reason I wanted to add this was to simplify it for the programmer. It took me several iterations until I made it run. I come from the bare metal embedded world, and usually when you have a project then you also add the IDE configuration files (there can be more than one), so anyone can just run it without any complications. I'll remove it
.vscode/launch.json
Outdated
} | ||
}, | ||
{ | ||
"name": "Debug DroneCAN GUI Tool (Module)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you trying to achieve by executing the main module?
With debug enabled, this simply outputs all the dsdl parser information as it is processed at startup. There is no usable application context run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are left overs from my attempts to make it run. I'll remove it
dronecan_gui_tool/version.py
Outdated
# | ||
# | ||
__version__ = 1, 2, 28 | ||
__version__ = 1, 2, 29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically, the version isn't bumped until the immediately before the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
2. Update .gitignore file to ignore virtual environments and vscode files 3. Restore the previous version to 1.2.28
@joshanne ,can you tell me where I can find instructions to how to distribute my code? I tried creating a task in vscode that does it (in windows). I was able to make it work, but for some reason when I start the Jupyter console it appears empty and It's not interactive. I would expect the repo to contain at least a .sh script for performing the distribution. |
Do you mean distributing the installer to install your version of the tool? Windows? or Linux?
On linux, judging by the github build tasks, you should be able to run the following to generate a wheel file for distribution. The wheel file will be in the
As for the interactive console not working, I'm unsure - I've not run into that problem. Whenever I launch the program, it seems to work as I expect. |
Other thing to note is
So make sure you have visual studio build tools installed, otherwise you can't build the |
@joshanne ,I was sure that winbuild.bat is for building, not creating an msi file, but as you mentioned, it was written in the README file. Thanks a lot. I tried it and it worked |