🩹 Fix path in artifact name for windows upload #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
path.Base only works with '/' while 'filepath.Glob' returns path with '\' on windows
s-weigand
force-pushed
the
fix-path-not-stripped-windows
branch
from
7152cb8
to
85fc41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the path is part of the artifact name with artifacts uploaded from windows.
The cause was that
path.Baseonly works with/whilefilepath.Globreturns paths with\on windows.vs.
I also applied this change to
writeChecksumssince having the original folder structure in the checksum file does not make sense when comparing it against the file on the release page.