Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go-terraform-address to parse address #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drlau
Copy link
Owner

@drlau drlau commented Aug 18, 2020

This PR updates parsing resource addresses to use hashicorp/go-terraform-address.

This PR will not be merged for now because it does not handle data paths:

  • data.mydata.path
  • module.mymodule.data.mydata.path
  • module.mymodule.data.data.data
--- FAIL: TestNewResourceChangeFromComment (0.00s)
    --- FAIL: TestNewResourceChangeFromComment/handles_modules_with_data_and_data_as_the_name (0.00s)
        resource_test.go:243: Unexpected error 1:26 (25): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF
    --- FAIL: TestNewResourceChangeFromComment/handles_modules_with_data (0.00s)
        resource_test.go:243: Unexpected error 1:28 (27): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF
    --- FAIL: TestNewResourceChangeFromComment/handles_data (0.00s)
        resource_test.go:243: Unexpected error 1:12 (11): no match found, expected: "[", [a-zA-Z0-9_-]i or EOF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant