[cmd/validate] add a flag to require names for all resources #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While targeting all instances of a specific resource type is convenient, sometimes we want to ensure we're not being too broad with our changes. This `requireName` key can be used to ensure that all resources in the ruleset are explicitly named.
This should allow for this to be re-used for other subcommands that need access to the ruleset, but do not need a Comparer.
Even though this subcommand isn't complete, this will now reveal any errors within the package.
A little bit more abstraction so that all the logic for validation does not happen within the cmd file.
This will be useful when writing validations across the different types of resource changes the ruleset supports.
Implements the logic for validating resources. Currently this only supports ensuring the ruleset has only named resources if the requireName is set.
Implements Stringer interface for `ResourceIdentifier` and `ValidateResult` for pretty printing.
drlau
reviewed
Apr 4, 2024
Co-authored-by: Dylan Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While targeting all instances of a specific resource type is convenient, sometimes we want to ensure we're not being too broad with our changes. This
requireNamekey can be used to ensure that all resources in the ruleset are explicitly named.Really, we can also add the
requireNamekey to a struct that is held byUpdateResourceChangeandCreateDeleteResourceChangeto allow for more granularity, but for now the use case I want this for is to enforce named resources for all changes in the ruleset