separate gRPC server create and serve. #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix issue: "grpc: Server.RegisterService after Server.Serve for" as the service register must happen before the Serve() function * upgrade some dependencies version
|
I made up for the test this time :) |
drgomesp
approved these changes
Aug 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 86.95% 86.36% -0.60%
==========================================
Files 3 3
Lines 46 44 -2
==========================================
- Hits 40 38 -2
Misses 4 4
Partials 2 2
☔ View full report in Codecov by Sentry. |
|
Thanks for the contribution @0xbillw ,really appreciated! I forgot I actually had setup some checks for code coverage. If you like to update the code to have a bit more coverage, please go ahead. Otherwise I can tweak the config later today and get this merged as it is. |
|
@drgomesp Sorry, I missed the unit test. I'm very much in favor of more code coverage, and I'll be adding unit tests again to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: "grpc: Server.RegisterService after Server.Serve for" as the service register must happen before the Serve() function
upgrade some dependencies version