Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate gRPC server create and serve (more code coverage) #10

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

0xbillw
Copy link
Contributor

@0xbillw 0xbillw commented Aug 9, 2023

  • fix issue: "grpc: Server.RegisterService after Server.Serve for" as the service register must happen before the Serve() function
  • upgrade some dependencies version

* fix issue: "grpc: Server.RegisterService after Server.Serve for" as the service register must happen before the Serve() function
* upgrade some dependencies version
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +6.22% 🎉

Comparison is base (ef416e7) 86.95% compared to head (0b5312b) 93.18%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   86.95%   93.18%   +6.22%     
==========================================
  Files           3        3              
  Lines          46       44       -2     
==========================================
+ Hits           40       41       +1     
+ Misses          4        2       -2     
+ Partials        2        1       -1     
Files Changed Coverage Δ
server.go 100.00% <100.00%> (+16.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drgomesp drgomesp merged commit f3864df into drgomesp:main Aug 9, 2023
11 checks passed
@0xbillw 0xbillw deleted the billw/separate_new_and_serve2 branch August 11, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants