Skip to content

Commit

Permalink
Fixes bug based on @jperdereau comment (#325)
Browse files Browse the repository at this point in the history 
Thank you!
  • Loading branch information
@dresende
dresende committed Nov 8, 2013
1 parent f8e238c commit ec4f70c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Drivers/DML/mysql.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function Driver(config, connection, opts) {
if (!this.config.timezone) {
this.config.timezone = "local";
}
this.query = new Query({ dialect: "mysql", timezone: config.timezone });
this.query = new Query({ dialect: "mysql", timezone: this.config.timezone });

this.reconnect(null, connection);

Expand Down

6 comments on commit ec4f70c

@micky2be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you publish/release that fix please. It's really hurting us!!

@dxg
Copy link
Collaborator

@dxg dxg commented on ec4f70c Jan 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dresende seems to be very busy lately, however in the mean time you could just change package.json to:

"orm": "git://github.com/dresende/node-orm2.git#ec4f70cf86095f2ed76834e26c5e5d6c76c6df56",

@vendethiel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are no tests :p

@micky2be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I'm using this module for a game in production with a considerable amount of users.
@dxg That's what I'm doing but this is far to be ideal and proper.
@Nami-Doc Do you really expect a test here? Isn't the bug and the fix for it obvious?

@vendethiel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the tests were passing before, then it does need a regression test. Else travis should say "test broke"

@dxg
Copy link
Collaborator

@dxg dxg commented on ec4f70c Jan 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do definitely need more tests. Contributions welcome :)

Please sign in to comment.