This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Allow the use of a Platform getting the certificate from settings.py #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to use Apple certs from settings if they are not saved on the Platform model, assumes only one push cert per deployment or environment. Order of precedence is model then settings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unclear from the docs how the settings described actually link up to using boto to make the necessary API calls with the correct credentials.
These changes allow settings to be used if the certificate credentials have not been applied to the model.
Do let me know if this is incorrect, if so the documentation needs to be updated to be clearer