Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove builtin global component #4714

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 24, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested review from jikkai and Jocs as code owners February 24, 2025 12:28
Copy link

github-actions bot commented Feb 24, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 32 seconds
commit  383636d
info  For more information, see full report

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.61%. Comparing base (2e59a6c) to head (383636d).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/ui/src/controllers/ui/ui-mobile.controller.tsx 0.00% 1 Missing ⚠️
.../ui/src/views/mobile-workbench/MobileWorkbench.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4714      +/-   ##
==========================================
- Coverage   32.63%   32.61%   -0.02%     
==========================================
  Files        2604     2605       +1     
  Lines      135773   135848      +75     
  Branches    30221    30228       +7     
==========================================
+ Hits        44304    44306       +2     
- Misses      91469    91542      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 51862a7 into dev Feb 25, 2025
9 checks passed
@wzhudev wzhudev deleted the refactor/remove-builtin-global-component branch February 25, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants