Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi rows& cols menu #4579

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

feat: add multi rows& cols menu #4579

wants to merge 11 commits into from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 5, 2025

close #4637
close https://github.com/dream-num/univer-pro/issues/3850

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 5, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 9, 2025

Playwright test results

failed  1 failed
passed  23 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 29 seconds
commit  02df8bf
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff set force string cell

@wzhudev
Copy link
Member

wzhudev commented Feb 10, 2025

If this PR is a WIP please make it a draft PR.

@lumixraku lumixraku force-pushed the feat/add-rows-menu branch 5 times, most recently from 6625f34 to 004bcf1 Compare February 13, 2025 08:43
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Feb 13, 2025
@lumixraku lumixraku marked this pull request as draft February 13, 2025 08:44
@lumixraku lumixraku force-pushed the feat/add-rows-menu branch 2 times, most recently from 4f0effa to d80a91f Compare February 13, 2025 09:06
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 3.00000% with 194 lines in your changes missing coverage. Please review.

Project coverage is 32.59%. Comparing base (4af5426) to head (38778cc).
Report is 43 commits behind head on dev.

Files with missing lines Patch % Lines
...ages/sheets-ui/src/controllers/menu/insert.menu.ts 0.00% 114 Missing ⚠️
...ts/src/commands/commands/insert-row-col.command.ts 5.19% 73 Missing ⚠️
packages/ui/src/components/menu/desktop/Menu.tsx 0.00% 4 Missing ⚠️
.../src/views/components/context-menu/ContextMenu.tsx 0.00% 2 Missing ⚠️
...ui/src/services/contextmenu/contextmenu.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4579      +/-   ##
==========================================
- Coverage   32.68%   32.59%   -0.09%     
==========================================
  Files        2603     2606       +3     
  Lines      135484   135896     +412     
  Branches    30124    30239     +115     
==========================================
+ Hits        44277    44302      +25     
- Misses      91207    91594     +387     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as ready for review February 13, 2025 09:44
@zhaolixin7
Copy link

右键菜单文案:丢了个“行”
image

@univer-bot
Copy link

univer-bot bot commented Feb 17, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Right-click menu copy: Lost a "route"
image

@lumixraku lumixraku force-pushed the feat/add-rows-menu branch 2 times, most recently from 6fec822 to 38778cc Compare February 22, 2025 04:51
chore: better code

feat: add multi rows
fix: menu position
test: fixed useEffect by add $ when trigger ctx menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The column width on the menu uses the value that was set last time
3 participants