Skip to content

Fix note autoresize loop #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Fix note autoresize loop #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/components/EditorCanvas/Note.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,15 @@ export default function Note({ data, onPointerDown }) {

const handleChange = (e) => {
const textarea = document.getElementById(`note_${data.id}`);
if (!textarea) return;
textarea.style.height = "0";
textarea.style.height = textarea.scrollHeight + "px";
const newHeight = textarea.scrollHeight + 42;
updateNote(data.id, { content: e.target.value, height: newHeight });
const updates = { content: e.target.value };
if (newHeight !== data.height) {
updates.height = newHeight;
}
updateNote(data.id, updates);
};

const handleBlur = (e) => {
Expand Down Expand Up @@ -181,11 +186,17 @@ export default function Note({ data, onPointerDown }) {

useEffect(() => {
const textarea = document.getElementById(`note_${data.id}`);
if (!textarea) return;

textarea.style.height = "0";
textarea.style.height = textarea.scrollHeight + "px";
const newHeight = textarea.scrollHeight + 42;
const scrollHeight = textarea.scrollHeight;
textarea.style.height = scrollHeight + "px";
const newHeight = scrollHeight + 42;

if (newHeight === data.height) return;

updateNote(data.id, { height: newHeight });
}, [data.id, updateNote]);
}, [data.id, data.height, updateNote]);

return (
<g
Expand Down Expand Up @@ -339,7 +350,10 @@ export default function Note({ data, onPointerDown }) {
onPointerMove={(e) => {
if (!resizing) return;
const delta = e.movementX / (transform?.zoom || 1);
const next = Math.max(MIN_NOTE_WIDTH, (data.width ?? noteWidth) + delta);
const next = Math.max(
MIN_NOTE_WIDTH,
(data.width ?? noteWidth) + delta,
);
if (next !== data.width) {
updateNote(data.id, { width: next });
}
Expand Down Expand Up @@ -514,4 +528,4 @@ export default function Note({ data, onPointerDown }) {
</foreignObject>
</g>
);
}
}
13 changes: 9 additions & 4 deletions src/context/NotesContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import { createContext, useState } from "react";
import { Action, ObjectType, defaultNoteTheme, noteWidth } from "../data/constants";
import { createContext, useState, useCallback } from "react";
import {
Action,
ObjectType,
defaultNoteTheme,
noteWidth,
} from "../data/constants";
import { useUndoRedo, useTransform, useSelect } from "../hooks";
import { Toast } from "@douyinfe/semi-ui";
import { useTranslation } from "react-i18next";
Expand Down Expand Up @@ -77,7 +82,7 @@ export default function NotesContextProvider({ children }) {
}
};

const updateNote = (id, values) => {
const updateNote = useCallback((id, values) => {
setNotes((prev) =>
prev.map((t) => {
if (t.id === id) {
Expand All @@ -89,7 +94,7 @@ export default function NotesContextProvider({ children }) {
return t;
}),
);
};
}, []);

return (
<NotesContext.Provider
Expand Down