-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Event Grid Reaction #134
Review Event Grid Reaction #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (10)
- reactions/azure/eventgrid-reaction/.dockerignore: Language not supported
- reactions/azure/eventgrid-reaction/.gitignore: Language not supported
- reactions/azure/eventgrid-reaction/Dockerfile: Language not supported
- reactions/azure/eventgrid-reaction/Makefile: Language not supported
- reactions/azure/eventgrid-reaction/Properties/.gitignore: Language not supported
- reactions/azure/eventgrid-reaction/eventgrid-reaction.csproj: Language not supported
- reactions/azure/eventgrid-reaction/eventgrid-reaction.sln: Language not supported
- reactions/azure/storagequeue-reaction/Dockerfile: Language not supported
- reactions/azure/eventgrid-reaction/Models/ChangeNotification.cs: Evaluated as low risk
- reactions/azure/eventgrid-reaction/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
reactions/azure/eventgrid-reaction/Services/ControlSignalHandler.cs:57
- Verify that 'ControlSignalNotificationOp.X' is the correct value for the 'Op' property in 'ControlSignalNotification'.
Op = ControlSignalNotificationOp.X,
foreach (var notification in formattedResults) | ||
{ | ||
CloudEvent currEvent = new CloudEvent(evt.QueryId, "Drasi.ChangeEvent", notification); | ||
var currResp = await _publisherClient.SendEventAsync(currEvent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does EventGrid have a batch send call? So they could all fail/pass together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's possible. We can combine them into a list of cloudevents and send this batch using SendEventAsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just committed this change
Description
Updated the EventGrid Reaction to use the nuget Reaction SDK and enabled authentication via managed identity. Currently the reaction only supports EventGrids that have the input schema of
CloudEventSchemaV1_0
.Configuration
The reaction takes the following configuration properties:
Example with Access Key
Example with Managed identity
Type of change
Fixes: #issue_number