Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mark2confluence): Skip files beginning with Space header when injecting default parents #19

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

gmarraff
Copy link
Collaborator

#17 introduced the possibility to inject default mark headers if the files was placed under certain directories.

However if a file already contained a mark Space header, the file would have end up having two Space headers, making mark to fail.

This PR fixes it by skipping files that begins with a mark Space header.

@gmarraff gmarraff requested a review from a team as a code owner January 31, 2024 10:25
mbovo
mbovo previously approved these changes Jan 31, 2024
Base automatically changed from fix-check-mark-headers-at-beginning to main January 31, 2024 11:05
@gmarraff gmarraff dismissed mbovo’s stale review January 31, 2024 11:05

The base branch was changed.

@mbovo mbovo self-requested a review January 31, 2024 11:08
@mbovo mbovo merged commit 04c7b22 into main Jan 31, 2024
3 checks passed
@mbovo mbovo deleted the fix-default-parents-skip-space branch January 31, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants