1.2 Fixes #38

rarchk · 2024-01-07T11:52:28Z

PR Type

Supports OCI based helm packages
Standardized arguments from each action (currently highly inconsistent)
Better logging and debugging support

What kind of change does this PR introduce?

Jira Link

What's New?

Describe your PR here

Other info

Click for more info

Your diff here

diff based workflow committed

adding debug statements.

chart not present error handled

adding much simpler fixes.

Pre commit hooks

event export

Pre commit hooks

adding non-failable differ

updating generalized helm differ

undo -u changes

* Adding audit code * removing typo. * adding binary path * adding more values * Updating ark support. * update helm version * update polaris version * updated serverless chart naming conventions * moving away from git fetch workflow * removing version of arkade * Changed helm diff logic * updating README --------- Co-authored-by: rarchk <[email protected]>

mbovo

Hi @rarchk-amagi @rarchk thanks for your pull request.

There are a lot of changes here that are not really "minor fixes" for 1.2 release; for example the introduction of new tooling or the change of input names that leads to break the backward compatibility.
I'm asking here to separate all these features into different PRs to be easily reviewed and in order to lead to major versions bump.

mbovo · 2024-01-09T11:33:54Z

README.md

- `publish` - Uses helm artifactory plugin to uploads the chart
+- `publish-artifactory` - Uses helm artifactory plugin to uploads the chart
+- `publish-chartmuseum` - Uses helm cm plugin to uploads the chart


This is a breaking change, it cannot be marked as 1.2 fixes

mbovo · 2024-01-09T11:34:22Z

README.md

-        uses: draios/[email protected]
+        uses: rarchk/[email protected]


please revert to the original repo

mbovo · 2024-01-09T11:34:34Z

README.md

+      - name: "Helm publish artifactory"
+        uses: rarchk/[email protected]


please revert to the original repo

mbovo · 2024-01-09T11:34:43Z

README.md

-        uses: draios/[email protected]
+        uses: rarchk/[email protected]


mbovo · 2024-01-09T11:34:55Z

README.md

-          action: "publish"
+          action: "publish-artifactory"


mbovo · 2024-01-09T11:35:43Z

README.md

+It statically audits k8s resources
+```yaml
+      - name: "Helm audit"
+        uses: rarchk/[email protected]
+        env:


The example should reflect the name of the repo

mbovo · 2024-01-09T11:37:05Z

common.sh

-export HELM_VERSION=${HELM_VERSION:="3.5.1"}
-export KUBECTL_VERSION=${KUBECTL_VERSION:="1.21.0"}
+export HELM_VERSION=${HELM_VERSION:="v3.13.3"}
+export KUBECTL_VERSION=${KUBECTL_VERSION:="v1.28.0"}
 export HELM_ARTIFACTORY_PLUGIN_VERSION=${HELM_ARTIFACTORY_PLUGIN_VERSION:="v1.0.2"}
+export HELM_CHARTMUSEUM_PLUGIN_VERSION=${HELM_CHARTMUSEUM_PLUGIN_VERSION:="0.10.3"}
 export CHART_VERSION=${CHART_VERSION:=""}
 export CHART_APP_VERSION=${CHART_APP_VERSION:=""}
+export DYFF_VERSION=${DYFF_VERSION:="1.6.0"}
+export YQ_VERSION=${YQ_VERSION:="v4.40.5"}
+export POLARIS_VERSION=${POLARIS_VERSION:="8.5.3"}
+export KUBE_SCORE_VERSION=${KUBE_SCORE_VERSION:="1.17.0"}


Changing these version requires a full non-regression test run, it cannot be applied as 1.2 fixes, they need a new major version (especially true for kubectl and helm versions)

mbovo · 2024-01-09T11:37:38Z

common.sh

+    print_title "Installing helm:${HELM_VERSION}"
+    ark get helm --version "${HELM_VERSION}" --quiet
+    helm version --short -c


It's nice to use arkade to install tooling but again this cannot be considered a minor fix

mbovo · 2024-01-09T11:39:13Z

common.sh

+install_dyff() {
+    if ! command -v dyff; then
+        echo "dyff is missing"
+        get_dyff
+    elif ! [[ $(dyff version) == *${DYFF_VERSION}* ]]; then
+        echo "dyfff $(dyff version) is not desired version"
+        get_dyff
+    fi
+}
+
+get_dyff() {
+    print_title "Installing dyff:${DYFF_VERSION}"
+    curl -L "https://github.com/homeport/dyff/releases/download/v${DYFF_VERSION}/dyff_${DYFF_VERSION}_linux_amd64.tar.gz" | tar xvz
+    chmod +x dyff
+    sudo mv dyff /usr/local/bin/dyff
+}
+
+install_polaris() {
+    if ! command -v polaris; then
+        print_title "Installing polaris:${POLARIS_VERSION}"
+        ark get polaris  --version "${POLARIS_VERSION}" --quiet
+    fi
+    polaris version
+    if ! command -v kube-score; then
+        print_title "Installing kube-score:${POLARIS_VERSION}"
+        curl -L "https://github.com/zegl/kube-score/releases/download/v${KUBE_SCORE_VERSION}/kube-score_${KUBE_SCORE_VERSION}_linux_amd64.tar.gz" | tar xvz
+        chmod +x kube-score
+        sudo mv kube-score /usr/local/bin/kube-score
+    fi
+    kube-score version
+}


This could be considered a change per se, adding new features

rarchk-amagi and others added 30 commits May 31, 2023 19:41

Added chartmuseum support

c99fb9a

update README

1debf94

updated github release version

9560a6f

updated github release version

34d6a1d

upload an existing chart

afeb638

update chart version

a08756a

diff based workflow committed

3c4ca0b

Merge pull request #1 from rarchk/pre-commit-hooks

2241af0

diff based workflow committed

adding debug statements.

f9cb843

Merge pull request #2 from rarchk/pre-commit-hooks

4e298cd

adding debug statements.

chart not present error handled

feda721

Merge pull request #3 from rarchk/pre-commit-hooks

d18f0aa

chart not present error handled

adding much simpler fixes.

0bdada7

Merge pull request #4 from rarchk/pre-commit-hooks

a32d9e6

adding much simpler fixes.

adding lint and diff action separately

58008df

removing dependency of PR number from output.

be0b1cf

Merge pull request #5 from rarchk/pre-commit-hooks

9ddb8fc

Pre commit hooks

event export

3b46546

Merge pull request #6 from rarchk/pre-commit-hooks

ed61ce9

event export

updated hlem checks.

df39c8d

updated hlem checks.

2718b4a

fixing typo

1d7ece7

Merge pull request #7 from rarchk/pre-commit-hooks

100554b

Pre commit hooks

adding non-failable differ

5733053

Merge pull request #8 from rarchk/pre-commit-hooks

a40d904

adding non-failable differ

updating generalized helm differ

4e3adbb

Merge pull request #9 from rarchk/pre-commit-hooks

97e7a5b

updating generalized helm differ

undo -u changes

76d59fd

Merge pull request #10 from rarchk/pre-commit-hooks

661b88d

undo -u changes

undo -u changes

f0a8f39

rarchk and others added 3 commits October 25, 2023 18:09

Merge pull request #11 from rarchk/pre-commit-hooks

6f18fed

undo -u changes

Removed helm chart version dependency to package contruct

78d27e7

rarchk requested a review from a team as a code owner January 7, 2024 11:52

mbovo requested changes Jan 9, 2024

View reviewed changes

mbovo mentioned this pull request Jan 9, 2024

Pre commit hooks #37

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.2 Fixes #38

1.2 Fixes #38

rarchk commented Jan 7, 2024

mbovo left a comment •

edited

Loading

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

mbovo Jan 9, 2024

		uses: draios/[email protected]
		uses: rarchk/[email protected]

		- name: "Helm publish artifactory"
		uses: rarchk/[email protected]

1.2 Fixes #38

Are you sure you want to change the base?

1.2 Fixes #38

Conversation

rarchk commented Jan 7, 2024

PR Type

What's New?

Other info

mbovo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbovo left a comment •

edited

Loading