expose hunspell version with --version
#229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
checker / hunspell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Currently it's not clear which hunspell version is used without additional user interaction.
The goal of this PR to close this gap and replace the manual actions with API in both hunspell and logic around it to obtain the hunspell version.
Ref #221
Changes proposed by this PR:
Introduce a
::versioninto the hunspell API re-exposing some C define / function. Also provide how thehunspelllib was linked (vendored,static,dynamic).Notes to reviewer:
Most of the changes will be in
drahnr/hunspell-rsorhunspell-sys, the PR merely exposes them via--version.📜 Checklist
./demosub directory