Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use /dev/stdin as SOURCE path for image build #1407

Closed
wants to merge 1 commit into from

Conversation

zyfjeff
Copy link
Contributor

@zyfjeff zyfjeff commented Aug 28, 2023

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Support use /proc/self/fd/0 as SOURCE path for image build

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@zyfjeff zyfjeff requested a review from a team as a code owner August 28, 2023 05:51
@zyfjeff zyfjeff requested review from bergwolf, liubin and luodw and removed request for a team August 28, 2023 05:52
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1407 (92239eb) into master (1abf0ae) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   46.45%   46.46%           
=======================================
  Files         123      123           
  Lines       38602    38607    +5     
  Branches    38602    38607    +5     
=======================================
+ Hits        17931    17937    +6     
+ Misses      19702    19696    -6     
- Partials      969      974    +5     
Files Changed Coverage Δ
src/bin/nydus-image/main.rs 41.58% <71.42%> (+0.59%) ⬆️

... and 4 files with indirect coverage changes

@zyfjeff zyfjeff force-pushed the support-char-devcie branch from 35de660 to 189459b Compare August 28, 2023 06:31
@zyfjeff zyfjeff force-pushed the support-char-devcie branch from 189459b to 92239eb Compare August 28, 2023 06:35
@zyfjeff zyfjeff changed the title Support use /proc/self/fd/0 as SOURCE path for image build Support use /dev/stdin as SOURCE path for image build Aug 28, 2023
@zyfjeff zyfjeff closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants