Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql database support #200

Closed
wants to merge 20 commits into from
Closed

Conversation

clcc2019
Copy link

Description

Related Issue

Motivation and Context

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clcc2019 Please add changelog and update chart version, refer to https://github.com/dragonflyoss/helm-charts/pull/190/files.

Helm charts use helm-docs to generate helm documents, refer to https://github.com/dragonflyoss/helm-charts/tree/main/charts.

Remove this.
image

# -- External postgresql port.
port: 5432


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank lines.

@gaius-qi
Copy link
Member

@clcc2019 Please rebase main branch.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clcc2019 Remove blank line.

image

@@ -3,7 +3,7 @@ name: dragonfly
description: Dragonfly is an intelligent P2P based image and file distribution system
icon: https://raw.githubusercontent.com/dragonflyoss/Dragonfly2/main/docs/images/logo/dragonfly.svg
type: application
version: 1.1.9
version: 1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version: 1.1.10

@@ -26,8 +26,8 @@ sources:

annotations:
artifacthub.io/changes: |
- Add syncPeers configuration to manager.
- Update dragonfly image tag to v2.1.16.
- Add postgresql database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Add postgresql database config.

- Add syncPeers configuration to manager.
- Update dragonfly image tag to v2.1.16.
- Add postgresql database
- Fix dfdaemon seedPeer configmap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Fix dfdaemon seedPeer configmap.

@gaius-qi
Copy link
Member

@clcc2019 Please fix lint.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint.

@teszes
Copy link

teszes commented Oct 31, 2023

@clcc2019 Are you still working on this? This would be useful to me too, and it seems there is only some lint errors to fix.

Also it might be worth it to link it to issue 176.

@clcc2019
Copy link
Author

clcc2019 commented Nov 1, 2023

Fix lint.

Can I skip the bitnami charts package check?

add postgresql wait container
@gaius-qi
Copy link
Member

gaius-qi commented Nov 6, 2023

Fix lint.

Can I skip the bitnami charts package check?

I don't think it's good.

@gaius-qi
Copy link
Member

@clcc2019 Please fix lint.

@gaius-qi
Copy link
Member

gaius-qi commented Jan 18, 2024

@clcc2019 Close PR due to no progress for a long time.

@gaius-qi gaius-qi closed this Jan 18, 2024
@lucasfcnunes
Copy link

@clcc2019 this PR is a great idea. I am really willing to take over and finish your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants