spec.serviceName on STS should be the same as metadata.name on Service #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EladDolev Please fix conflicting. Thanks! |
|
Hi @gaius-qi Have missed that email from GitHub a month ago, sorry for that I've updated my branch Can we reopen this PR or should I open a new one ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.serviceName on STS should be the same as metadata.name on correlating Service
Description
Fixes the following issue when Release.Name !=
dragonflyAlso changing the
spec.serviceNameon the seedPeer STS even though a Service does not exist for it. For our use-case we actually creating a Service for it, and I'm planning opening another PR for optionally creating a Service in the official chartPiggybacking changing the
appVersionfield value on Chart.yaml to the application's versionRelated Issue
#179