-
Notifications
You must be signed in to change notification settings - Fork 348
[WIP] feat: Add cache encryption implementation for Storage #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ChoHee15
wants to merge
7
commits into
dragonflyoss:main
Choose a base branch
from
ChoHee15:encryption
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaWhispers
reviewed
Sep 1, 2025
cb37df9
to
a7184dd
Compare
Signed-off-by: chohee <[email protected]>
- Reduce nesting in initializeEncryptionKey - Normalize log messages to lowercase Signed-off-by: chohee <[email protected]>
- Add response with error when encryption is disabled but clients request key Signed-off-by: chohee <[email protected]>
Signed-off-by: chohee <[email protected]>
Signed-off-by: chohee <[email protected]>
a7184dd
to
9396538
Compare
Signed-off-by: chohee <[email protected]>
Signed-off-by: chohee <[email protected]>
9396538
to
a3e9578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new
encrypt
component for Storage, providing an optional encryption feature. This solution will enhance the security of the data stored locally.Related Issue
dragonflyoss/design#9
Motivation and Context
#4026
Screenshots (if appropriate)
Types of changes
Checklist