feat: add 'LoadToCache' in Download message when starting a preheat job #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: southwest <[email protected]>
Signed-off-by: southwest <[email protected]>
SouthWest7
changed the title
gaius-qi
requested changes
Jan 21, 2025
| @@ -307,6 +307,7 @@ func (j *job) preheatAllSeedPeers(ctx context.Context, taskID string, req *inter | |||
| RequestHeader: req.Headers, | |||
| Timeout: durationpb.New(req.Timeout), | |||
| CertificateChain: req.CertificateChain, | |||
| LoadToCache: true, | |||
There was a problem hiding this comment.
Why need to force the specification of true and pass it in through parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces the LoadToCache field in the Download message, which is used to indicate whether content should be loaded into the memory cache during a preheat job.
LoadToCacheto true in three scopes:Single Seed Peer,All Seed PeersandAll Peers.Related Issue
#3742
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist