Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the token-permission and pinned dependencies #3442

Closed

Conversation

harshitasao
Copy link
Contributor

Description

fixed the token-permission and pinned dependencies reported by scorecard.

Related Issue

Part of #3441

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.53%. Comparing base (d68e707) to head (728f3f1).
Report is 40 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   52.64%   52.53%   -0.11%     
==========================================
  Files         194      194              
  Lines       20587    20587              
==========================================
- Hits        10837    10815      -22     
- Misses       8942     8962      +20     
- Partials      808      810       +2     
Flag Coverage Δ
unittests 52.53% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitasao Is it possible to use verison instead of git commit?

@gaius-qi gaius-qi closed this Sep 10, 2024
@gaius-qi gaius-qi reopened this Sep 18, 2024
@gaius-qi
Copy link
Member

Refer to #3513.

@gaius-qi gaius-qi closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants