Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add piece lenght, tag, application test cases for dfget downloading #3207

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 22, 2024

Description

Related Issue

dragonflyoss/client#398

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Apr 22, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Apr 22, 2024
@gaius-qi gaius-qi self-assigned this Apr 22, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner April 22, 2024 03:23
@gaius-qi gaius-qi requested review from jim3ma, yxxhero and akashhr April 22, 2024 03:23
@gaius-qi gaius-qi changed the title test: add piece lenght, tag, application test cases for dfget downloa… test: add piece lenght, tag, application test cases for dfget downloading Apr 22, 2024
@gaius-qi gaius-qi force-pushed the feature/dfget-test branch from 919370a to 44a2e39 Compare April 22, 2024 03:46
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.00%. Comparing base (3a4a053) to head (44a2e39).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
+ Coverage   51.96%   52.00%   +0.04%     
==========================================
  Files         173      173              
  Lines       19382    19382              
==========================================
+ Hits        10072    10080       +8     
+ Misses       8601     8595       -6     
+ Partials      709      707       -2     
Flag Coverage Δ
unittests 52.00% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 76dd8a1 into main Apr 22, 2024
14 of 23 checks passed
@gaius-qi gaius-qi deleted the feature/dfget-test branch April 22, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant