feat(dfdaemon): add disk usage metrics #2912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 51.06% 51.00% -0.07%
==========================================
Files 161 161
Lines 21778 21797 +19
==========================================
- Hits 11122 11118 -4
- Misses 9999 10021 +22
- Partials 657 658 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xujihui1985
commented
Dec 4, 2023
jim3ma
requested changes
Jan 11, 2024
| metrics.DataUnReclaimedUsage.Set(float64(totalNotMarkedSize)) | ||
| metrics.DataDiskGCThreshold.Set(float64(s.storeOption.DiskGCThreshold)) | ||
| metrics.DataDiskGCThresholdPercent.Set(s.storeOption.DiskGCThresholdPercent) | ||
|
|
There was a problem hiding this comment.
The s.storeOption.DiskGCThresholdPercent and s.storeOption.DiskGCThreshold is static, we should not update them every time.
There was a problem hiding this comment.
yes, this is used to record the threshold, so that we can display on the monitor, or there is better way to achieve that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
collect disk usage metrics for dfdaemon
Related Issue
Motivation and Context
currently there is no disk usage metrics for data directory usage, we need to monitor the disk dfdaemon used
Screenshots (if appropriate)
Types of changes
Checklist