Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ParentSelector configuration for dfdaemon #917

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add ParentSelector configuration for dfdaemon #917

wants to merge 3 commits into from
+51 −0

Conversation

baowj-678
Copy link

@baowj-678 baowj-678 commented Dec 27, 2024 •
edited
Loading

Description

upload:
  # configuration for HostSyncer
  parentSelector:
    # enable indicates whether enable HostSyncer.
    enable: true
    # intervalis the interval to sync hosts' info.
    syncInterval: 3s
    # cacheCapacity is the capacity of the cache by LRU algorithm for HostSyncer grpc connection, default is 50.
    capacity: 50

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)
    Checklist
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@baowj-678 baowj-678 requested a review from a team as a code owner December 27, 2024 08:48
gaius-qi
gaius-qi requested changes Dec 31, 2024
View reviewed changes
dragonfly-client-config/src/dfdaemon.rs Outdated Show resolved Hide resolved
dragonfly-client-config/src/dfdaemon.rs Outdated Show resolved Hide resolved
dragonfly-client-config/src/dfdaemon.rs Show resolved Hide resolved
gaius-qi
gaius-qi requested changes Dec 31, 2024
View reviewed changes
dragonfly-client-config/src/dfdaemon.rs Outdated Show resolved Hide resolved
@baowj-678 baowj-678 changed the title feat: add HostSyncer configuration for dfdaemon feat: add ParentSelector configuration for dfdaemon Dec 31, 2024
gaius-qi
gaius-qi requested changes Dec 31, 2024
View reviewed changes
dragonfly-client-config/src/dfdaemon.rs Outdated
@@ -571,6 +604,9 @@ pub struct Upload {
/// client is the upload client configuration for dfdaemon.
pub client: UploadClient,

/// parent_selector is the host syncer configuration for dfdaemon.
pub parent_selector: ParentSelector,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to the pub struct Download.

gaius-qi
gaius-qi requested changes Jan 2, 2025
View reviewed changes
dragonfly-client-config/src/dfdaemon.rs
@@ -561,6 +578,40 @@ impl UploadClient {
}
}

/// ParentSelector is the download parent selector configuration for dfdaemon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi requested changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@mfarooq-tech mfarooq-tech Awaiting requested review from mfarooq-tech mfarooq-tech is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baowj-678 @gaius-qi