Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate piece range and store the actual piece reader #906

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces several changes to the dragonfly-client-storage and related modules to enhance the reading and caching mechanisms, as well as to improve the upload functionality. The most important changes include adding dual read functionality, refactoring existing read methods to use buffered readers, and updating the cache logic.

Enhancements to Reading and Caching Mechanisms:

Improvements to Upload Functionality:

Refactoring and Code Simplification:

Miscellaneous Updates:

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 19, 2024
@gaius-qi gaius-qi added this to the v1.0.0 milestone Dec 19, 2024
@gaius-qi gaius-qi self-assigned this Dec 19, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner December 19, 2024 12:48
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (64341d6) to head (164b6c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/proxy/cache.rs 0.00% 38 Missing ⚠️
dragonfly-client/src/proxy/mod.rs 0.00% 30 Missing ⚠️
dragonfly-client-storage/src/content.rs 0.00% 19 Missing ⚠️
dragonfly-client/src/resource/piece.rs 0.00% 8 Missing ⚠️
dragonfly-client-storage/src/lib.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   33.86%   33.63%   -0.23%     
==========================================
  Files          60       60              
  Lines        9034     9095      +61     
==========================================
  Hits         3059     3059              
- Misses       5975     6036      +61     
Files with missing lines Coverage Δ
...onfly-client/src/resource/persistent_cache_task.rs 0.00% <ø> (ø)
dragonfly-client/src/resource/task.rs 0.00% <ø> (ø)
dragonfly-client-storage/src/lib.rs 1.96% <0.00%> (-0.04%) ⬇️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/piece.rs 61.51% <0.00%> (-1.83%) ⬇️
dragonfly-client-storage/src/content.rs 2.89% <0.00%> (-0.41%) ⬇️
dragonfly-client/src/proxy/mod.rs 0.00% <0.00%> (ø)
dragonfly-client/src/proxy/cache.rs 0.00% <0.00%> (ø)

@gaius-qi gaius-qi merged commit 6ace03a into main Dec 19, 2024
6 checks passed
@gaius-qi gaius-qi deleted the feature/range branch December 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants