Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace redirect_stderr with args.verbose #905

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 19, 2024

Description

This pull request includes several changes to the dragonfly-client project, focusing on improving logging and updating dependencies. The most important changes include updating the lru crate version, adding a new logging statement, and modifying the tracing initialization logic.

Dependency Update:

  • Updated the lru crate version to 0.12.5 in Cargo.toml.

Logging Enhancements:

  • Added a new logging statement using tracing::info in dragonfly-client/src/proxy/cache.rs.

Tracing Initialization:

  • Removed the redirect_stderr parameter from the init_tracing function in dragonfly-client/src/tracing/mod.rs.
  • Changed the logic to redirect stderr to a file only if verbose is not enabled in dragonfly-client/src/tracing/mod.rs.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 19, 2024
@gaius-qi gaius-qi added this to the v1.0.0 milestone Dec 19, 2024
@gaius-qi gaius-qi self-assigned this Dec 19, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner December 19, 2024 04:00
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (4f97de3) to head (2764531).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/tracing/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   33.83%   33.86%   +0.02%     
==========================================
  Files          60       60              
  Lines        9040     9034       -6     
==========================================
  Hits         3059     3059              
+ Misses       5981     5975       -6     
Files with missing lines Coverage Δ
dragonfly-client-init/src/bin/main.rs 0.00% <ø> (ø)
dragonfly-client/src/bin/dfcache/main.rs 0.00% <ø> (ø)
dragonfly-client/src/bin/dfdaemon/main.rs 0.00% <ø> (ø)
dragonfly-client/src/bin/dfget/main.rs 26.45% <ø> (+0.03%) ⬆️
dragonfly-client/src/bin/dfstore/main.rs 0.00% <ø> (ø)
dragonfly-client/src/tracing/mod.rs 0.00% <0.00%> (ø)

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 64341d6 into main Dec 19, 2024
6 checks passed
@gaius-qi gaius-qi deleted the feature/stderr branch December 19, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants