Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename remote peer to parent #901

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: rename remote peer to parent #901

merged 1 commit into from
Dec 17, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request primarily involves renaming various functions, structs, and comments to replace references to "remote peer" with "parent" in the dragonfly-client project. The changes span multiple files and affect error handling, documentation, and function names to ensure consistency with the new terminology.

Renaming for Consistency:

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 17, 2024
@gaius-qi gaius-qi added this to the v1.0.0 milestone Dec 17, 2024
@gaius-qi gaius-qi self-assigned this Dec 17, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner December 17, 2024 08:04
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 33.80%. Comparing base (d6b613e) to head (3db2413).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onfly-client/src/resource/persistent_cache_task.rs 0.00% 6 Missing ⚠️
dragonfly-client/src/resource/task.rs 0.00% 6 Missing ⚠️
dragonfly-client/src/resource/piece_collector.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   33.80%   33.80%           
=======================================
  Files          60       60           
  Lines        9034     9034           
=======================================
  Hits         3054     3054           
  Misses       5980     5980           
Files with missing lines Coverage Δ
dragonfly-client-core/src/error/errors.rs 89.90% <ø> (ø)
dragonfly-client-core/src/error/mod.rs 59.09% <ø> (ø)
dragonfly-client-storage/src/lib.rs 2.00% <ø> (ø)
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <ø> (ø)
dragonfly-client/src/resource/piece.rs 63.33% <ø> (ø)
dragonfly-client/src/resource/piece_collector.rs 0.00% <0.00%> (ø)
...onfly-client/src/resource/persistent_cache_task.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/task.rs 0.00% <0.00%> (ø)

@gaius-qi gaius-qi merged commit c67f13e into main Dec 17, 2024
6 checks passed
@gaius-qi gaius-qi deleted the feature/remote-peer branch December 17, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants