Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support syncpeers by service and optimize the merge logic #3637

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

CormickKneey
Copy link
Contributor

Description

still in progress

Related Issue

#3634

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 29.03226% with 154 lines in your changes missing coverage. Please review.

Project coverage is 35.46%. Comparing base (b83a4c9) to head (207a410).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/sync_peers.go 28.57% 95 Missing ⚠️
manager/service/job.go 0.00% 35 Missing ⚠️
manager/handlers/job.go 8.33% 11 Missing ⚠️
manager/service/mocks/service_mock.go 0.00% 9 Missing ⚠️
manager/job/mocks/sync_peers_mock.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
+ Coverage   35.41%   35.46%   +0.04%     
==========================================
  Files         335      336       +1     
  Lines       37531    37657     +126     
==========================================
+ Hits        13293    13355      +62     
- Misses      23409    23471      +62     
- Partials      829      831       +2     
Flag Coverage Δ
unittests 35.46% <29.03%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/config/config.go 96.29% <100.00%> (+0.01%) ⬆️
manager/service/service.go 0.00% <ø> (ø)
pkg/container/slice/slice.go 100.00% <100.00%> (ø)
scheduler/resource/standard/host.go 88.23% <100.00%> (ø)
manager/job/mocks/sync_peers_mock.go 0.00% <0.00%> (ø)
manager/service/mocks/service_mock.go 95.40% <0.00%> (-1.15%) ⬇️
manager/handlers/job.go 50.00% <8.33%> (-5.56%) ⬇️
manager/service/job.go 0.00% <0.00%> (ø)
manager/job/sync_peers.go 18.71% <28.57%> (+18.71%) ⬆️

... and 2 files with indirect coverage changes

manager/job/sync_peers.go Outdated Show resolved Hide resolved
manager/config/config.go Outdated Show resolved Hide resolved
@CormickKneey CormickKneey changed the title [WIP] enhance: support syncpeers by service and optimize the merge logic enhance: support syncpeers by service and optimize the merge logic Nov 17, 2024
@CormickKneey CormickKneey marked this pull request as ready for review November 19, 2024 07:21
@CormickKneey CormickKneey requested a review from a team as a code owner November 19, 2024 07:21
manager/job/sync_peers.go Outdated Show resolved Hide resolved
manager/service/job.go Outdated Show resolved Hide resolved
manager/job/sync_peers.go Outdated Show resolved Hide resolved
manager/job/sync_peers.go Outdated Show resolved Hide resolved
Signed-off-by: cormick <[email protected]>
chlins
chlins previously approved these changes Nov 26, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove lo library and define the func in pkg/container/map/map.go.

manager/job/sync_peers.go Outdated Show resolved Hide resolved
Signed-off-by: cormick <[email protected]>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit d0e41b5 into dragonflyoss:main Nov 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants