chore: clean up sanitizers checks #6173
Open
+1
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| add_library(dfly_test_lib test_utils.cc) | ||
| cxx_link(dfly_test_lib dragonfly_lib facade_test gtest_main_ext) | ||
|
|
There was a problem hiding this comment.
With SANITIZERS no longer defined for dfly_test_lib, src/server/test_utils.cc will not take its #elif defined SANITIZERS branch (larger fiber stack under sanitizers). This may reduce the default stack size under ASAN/UBSAN and lead to stack overflows or test flakiness.
🤖 Was this useful? React with 👍 or 👎
Signed-off-by: Roman Gershman <[email protected]>
kostasrim
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.