chore: use BackedArguments for implementing a pipeline message #6167
+76
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces BackedArguments, a new class for managing heap-allocated command arguments to support async dispatch. It also establishes a new common/ directory for low-level utilities shared across facade, core, and server components, moving StringOrView and HeapSize from the dfly:: namespace to cmn::.
Key changes:
- New
BackedArgumentsclass with move semantics for managing arguments with backing storage - Refactored
PipelineMessageto inherit fromBackedArgumentsinstead of embedding its own storage - Moved utilities to
common/namespace and updated all references throughout the codebase
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/backed_args.h | New file defining BackedArguments class with storage and move semantics |
| src/common/string_or_view.h | Moved from core/, changed namespace from dfly:: to cmn:: |
| src/common/heap_size.h | Changed namespace from dfly:: to cmn:: |
| src/facade/dragonfly_connection.h | PipelineMessage now inherits BackedArguments, simplified interface |
| src/facade/dragonfly_connection.cc | Updated PipelineMessage::SetArgs and FromArgs to use BackedArguments base class |
| src/facade/conn_context.h | Removed unused heap_size.h include |
| src/facade/conn_context.cc | Updated HeapSize references to cmn::, removed retired flag |
| src/facade/redis_parser.cc | Updated HeapSize references to cmn:: |
| src/facade/redis_parser_test.cc | Updated HeapSize references to cmn:: |
| src/facade/reply_builder.cc | Commented out unused heap_size.h include |
| src/server/conn_context.cc | Updated HeapSize references to cmn:: |
| src/server/db_slice.h | Updated StringOrView include path |
| src/server/detail/wrapped_json_path.h | Updated StringOrView references to cmn:: |
| src/server/snapshot.cc | Removed unused heap_size.h include |
| src/server/tiering/decoders.h | Removed StringOrView include (now transitive via compact_object.h) |
| src/core/compact_object.h | Updated StringOrView include and added using declaration |
| src/core/search/indices.h | Updated StringOrView include path |
| src/core/search/indices.cc | Added using declaration for cmn::StringOrView |
dranikpg
reviewed
Dec 5, 2025
dranikpg
reviewed
Dec 5, 2025
romange
force-pushed
the
Pr3
branch
3 times, most recently
from
abf86d0 to
1e57dbf
Compare
romange
changed the title
romange
force-pushed
the
Pr3
branch
2 times, most recently
from
1f1d27f to
2245d6d
Compare
dranikpg
previously approved these changes
Dec 7, 2025
Remove duplicate code for building backed arguments, similarly to #6171 Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate code for collapsing multiple blobs, similarly to #6171
Signed-off-by: Roman Gershman [email protected]