feat(search): Simple multi-reader multi-writer mutex for hnsw index #6156
+321
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaruza
force-pushed
the
mkaruza/simple-hnsw-locking
branch
from
54f8826 to
3ba0698
Compare
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| } | ||
|
|
||
| vector<pair<float, GlobalDocId>> Knn(float* target, size_t k, std::optional<size_t> ef) { | ||
| world_.setEf(ef.value_or(kDefaultEfRuntime)); |
There was a problem hiding this comment.
Consider moving the world_.setEf(...) call inside the MRMWMutexLock scope; setEf mutates shared state and, as written, can race with concurrent reads/writes. (Also applies to the filtered Knn overload below.)
🤖 Was this useful? React with 👍 or 👎
romange
reviewed
Dec 3, 2025
romange
reviewed
Dec 3, 2025
| return mode == LockMode::kReadLock ? LockMode::kWriteLock : LockMode::kReadLock; | ||
| } | ||
|
|
||
| util::fb2::Mutex mutex_; |
Collaborator
There was a problem hiding this comment.
nit: you also contend on mutex_, though here maybe absl::SpinLock would fit better as you take it for a small period of time. you could use CondVarAny to be able to use locks with a different type.
Collaborator
There was a problem hiding this comment.
not the most important thing though.
romange
reviewed
Dec 3, 2025
romange
previously approved these changes
Dec 3, 2025
kostasrim
reviewed
Dec 3, 2025
Implementation of multi-reader multi-writer mutex that supports concurrent writes or reads but not a mix of reads and writes in same time. Unit test for testing MRMWMutex class. Signed-off-by: mkaruza <[email protected]>
mkaruza
force-pushed
the
mkaruza/simple-hnsw-locking
branch
from
45a7599 to
11e61f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of multi-reader multi-writer mutex that supports concurrent writes or reads but not a mix of reads and writes in same time.
Unit test for testing MRMWMutex class.