Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dracut-install): Copy xattr when use clone ioctl #2660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dracut-install): Copy xattr when use clone ioctl #2660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
57 changes: 57 additions & 0 deletions src/install/dracut-install.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include <fts.h>
#include <regex.h>
#include <sys/utsname.h>
#include <attr/xattr.h>

#include "log.h"
#include "hashmap.h"
Expand Down Expand Up @@ -291,6 +292,56 @@ static inline int clone_file(int dest_fd, int src_fd)
return ioctl(dest_fd, BTRFS_IOC_CLONE, src_fd);
}

static int copy_xattr(int dest_fd, int src_fd)
{
int ret = 0;
ssize_t name_len = 0, value_len = 0;
char *name_buf = NULL, *name = NULL, *value = NULL, *value_save = NULL;

name_len = flistxattr(src_fd, NULL, 0);
if (name_len < 0)
return -1;

name_buf = calloc(1, name_len + 1);
if (name_buf == NULL)
return -1;

name_len = flistxattr(src_fd, name_buf, name_len);
if (name_len < 0)
goto out;

for (name = name_buf; name != name_buf + name_len; name = strchr(name, '\0') + 1) {
value_len = fgetxattr(src_fd, name, NULL, 0);
if (value_len < 0) {
ret = -1;
continue;
}

value_save = value;
value = realloc(value, value_len);
if (value == NULL) {
value = value_save;
ret = -1;
goto out;
}

value_len = fgetxattr(src_fd, name, value, value_len);
if (value_len < 0) {
ret = -1;
continue;
}

value_len = fsetxattr(dest_fd, name, value, value_len, 0);
if (value_len < 0)
ret = -1;
}

out:
free(name_buf);
free(value);
return ret;
}

static bool use_clone = true;

static int cp(const char *src, const char *dst)
Expand Down Expand Up @@ -332,6 +383,12 @@ static int cp(const char *src, const char *dst)
log_info("Failed to chown %s: %m", dst);
}

if (geteuid() == 0 && no_xattr == false) {
if (copy_xattr(dest_desc, source_desc) != 0)
log_error("Failed to copy xattr %s: %m", dst);

}

tv[0].tv_sec = sb.st_atime;
tv[0].tv_usec = 0;
tv[1].tv_sec = sb.st_mtime;
Expand Down