Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove False Positive Errors When Using 'livenet' And Squashfs #2595

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Mar 11, 2024

  1. fix(dmsquash-live): use load_fstype to load driver for filesystems

    Looking for directories in `/sys/fs` is not exhaustive. Not all available
    filesystems are listed there.
    
    A library function has been already developed for such a use case. It is
    `load_fstype``.
    
    This patch replaces custom code with a call to `load_fstype`
    
    Signed-off-by: Federico Vaga <[email protected]>
    Federico Vaga committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e8b7b6e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. fix(dmsquash-live): do not check ISO md5 if image filesystem

    The ISO checksum code was executed independently of the provided
    `$livedev`. Often, this is a loop device pointing to an ISO image, but
    in other cases `dmsquash-live-root` receives the path to a filesystem
    image. In this case, we can't use `udevadm` to extract information
    because it is not a device, and trying to do that leads to `udevadm`
    error messages (but not blocking).
    
    Therefore, the ISO checksum check must be performed only if the provided
    `$livedev` is **not** a regular file.
    
    Signed-off-by: Federico Vaga <[email protected]>
    Federico Vaga committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c8f1708 View commit details
    Browse the repository at this point in the history