feat(numlock): add module to turn Num Lock on #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innovara
force-pushed
the
add-numlock-module
branch
from
8b3af80
to
0879bb0
Compare
innovara
force-pushed
the
add-numlock-module
branch
from
0879bb0
to
76345c0
Compare
innovara
force-pushed
the
add-numlock-module
branch
from
76345c0
to
ac7391c
Compare
LaszloGombos
reviewed
Nov 4, 2023
innovara
force-pushed
the
add-numlock-module
branch
from
ac7391c
to
a993eb0
Compare
Conan-Kudo
approved these changes
Dec 29, 2023
innovara
force-pushed
the
add-numlock-module
branch
from
a993eb0
to
0ad456f
Compare
LaszloGombos
approved these changes
Dec 31, 2023
Conan-Kudo
approved these changes
Jan 3, 2024
|
May I ask what are the next steps on a PR of this kind? Is it going to be merged on a future release? Is there anything I can do to help the process? I'd love to see it on the next version of Fedora. |
3 tasks
This module adds setleds and a shell script to turn Num Lock on. Useful when you have to type a password or a PIN to unlock a volume.
innovara
force-pushed
the
add-numlock-module
branch
from
0ad456f
to
d72aa75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have to unlock an encrypted volume during bootup, it's generally, and arguably, more convenient to have Num Lock on by default to type your password. This is even more convenient when using hardware tokens, being smart cards or usb keys, as they generally use numeric PINs to unlock the slot holding the key.
The idea of how to do it comes from here: https://wiki.archlinux.org/title/Activating_numlock_on_bootup
Changes
This module adds setleds and a shell script to turn Num Lock on.
The module priority (90), the hook (initqueue/settled), and its priority (90) are purely my attempt at putting it where I think it can go. I chose the later hook in time for the unlocking of the encrypted volume, based on trial and error testing. I reckon the devs here can recommend changes in this regard.
Checklist