Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: remove undefined $libdir var ref in 01-systemd-repart #2536

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

berrange
Copy link
Contributor

Nothing in dracut appears to define the '$libdir' environment variable when module scripts are being run. As a result when the 01-systemd-repart module script runs, it fails to copy any of the config files into the initrd. Replace it with '/usr/lib' which reflects where systemd-repart expects its global config files.

@github-actions github-actions bot added the modules Issue tracker for all modules label Oct 17, 2023
Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, apparently no one has tested or used this module...

Minor nitpick, could you change the commit message to: fix(systemd-repart): correct undefined $libdir?

Nothing in dracut appears to define the '$libdir' environment
variable when module scripts are being run. As a result when
the 01-systemd-repart module script runs, it fails to copy any
of the config files into the initrd. Replace it with '/usr/lib'
which reflects where systemd-repart expects its global config
files.

Signed-off-by: Daniel P. Berrangé <[email protected]>
@LaszloGombos LaszloGombos merged commit 1586af0 into dracutdevs:master Oct 30, 2023
94 of 107 checks passed
@AdrianVovk
Copy link

apparently no one has tested or used this module.

The module is used and tested. It's just that systemd-repart will automatically look into /sysroot/usr/... for its config files whenever it can, instead of using the config in the initrd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants