fix(dracut.sh): use gawk for strtonum #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strtonum is a gawkism and is not available in all awks, e.g. mawk. Use gawk to avoid failure. Fixes: f32e95b Signed-off-by: Sam James <[email protected]>
|
cc @keentux |
|
Thanks @thesamesam . Make sense to me to land this as is, but I hope to improve it even further and support mawk by carrying our own strtonum implementation. |
LaszloGombos
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes dracut.sh and dracut-functions.sh to use
gawkinstead ofawkbecause we're usingstrtonum.strtonum is a gawkism and is not available in all awks, e.g. mawk. Use gawk to avoid failure.
Fixes: f32e95b
Changes
Checklist
Fixes #