Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dracut.sh): use gawk for strtonum #2436

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

thesamesam
Copy link
Contributor

This pull request changes dracut.sh and dracut-functions.sh to use gawk instead of awk because we're using strtonum.

strtonum is a gawkism and is not available in all awks, e.g. mawk. Use gawk to avoid failure.

Fixes: f32e95b

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • [N/A] I am providing new code and test(s) for it

Fixes #

strtonum is a gawkism and is not available in all awks, e.g. mawk. Use gawk
to avoid failure.

Fixes: f32e95b
Signed-off-by: Sam James <[email protected]>
@thesamesam
Copy link
Contributor Author

cc @keentux

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@LaszloGombos
Copy link
Collaborator

Thanks @thesamesam .

Make sense to me to land this as is, but I hope to improve it even further and support mawk by carrying our own strtonum implementation.

@LaszloGombos LaszloGombos merged commit 33a66ed into dracutdevs:master Jul 20, 2023
68 of 78 checks passed
@thesamesam thesamesam deleted the gawk branch July 20, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants