Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caps): multiple fixes #2435

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aafeijoo-suse
Copy link
Member

NOTE: still a draft, because I don't know if it's worth fixing this module nowadays.

Fixes:

  • fix(caps): /bin/bash is already installed by the bash module

  • fix(caps): add missing dependency from base module
    The caps.sh script calls getarg, which is in dracut-lib.sh.

  • fix(caps): replace kexec_disabled with kexec_load_disabled
    The original patch [1] with kexec_disabled was not merged, but it was
    patch [2] with kexec_load_disabled. Also, the kernel admin guide [3] only
    mentions the latter.

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://github.com/torvalds/linux/blob/fdf0eaf11452d72945af31804e2a1048ee1b574c/Documentation/admin-guide/sysctl/kernel.rst?plain=1#L453-L465

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@github-actions github-actions bot added modules Issue tracker for all modules caps Issues related to the caps module labels Jul 18, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Sep 16, 2023
@aafeijoo-suse aafeijoo-suse removed the stale communication is stuck label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caps Issues related to the caps module modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant