Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: temperature not showing for certain weather info #320

Merged

Conversation

wisscot
Copy link
Contributor

@wisscot wisscot commented Jan 4, 2025

To fix issue #318

@Theoreticallyhugo
Copy link
Collaborator

Thank you for your contribution!

considering your issue, i assume that you've tested this on ubuntu?

@wisscot
Copy link
Contributor Author

wisscot commented Jan 4, 2025

yes, it works on ubuntu

@Theoreticallyhugo
Copy link
Collaborator

testing on a fresh fedora 41, both the original code, as well as your fix is working.
if it works on macos too, i would wait for a few days for others to check and then it would be ok to be merged imo.

@ethancedwards8
Copy link
Member

ethancedwards8 commented Jan 4, 2025

Works on MacOS. Thanks! When you're ready, merge it in, @Theoreticallyhugo !

@Theoreticallyhugo Theoreticallyhugo merged commit 1f7f091 into dracula:master Jan 4, 2025
1 check passed
@Theoreticallyhugo
Copy link
Collaborator

Awesome!
Thanks a lot for your contribution @wisscot :D

@wisscot
Copy link
Contributor Author

wisscot commented Jan 5, 2025

Thank you both for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants