Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework odd #67

Open
wants to merge 13 commits into
base: rework-odd
Choose a base branch
from
Open

Rework odd #67

wants to merge 13 commits into from

Conversation

ingoboerner
Copy link
Collaborator

Create a TEI customization (based on TEI Drama ODD) that implements the necessary restrictions for the DraCor API to work.

The derived schema can be used to validate TEI files to be included in DraCor corpora. It allows for greater flexibility in the application of the TEI Guidelines than the original "legacy" ODD derived schema.

The conformance to the API will be tested with Schematron rules that are embedded into the RelaxNG schema.

The ODD also includes definitions for the so-called "features" that were identified in the CLS INFRA Deliverable "On Programmable Corpora" (https://zenodo.org/records/7664964). It includes the explanations of the features developed for the API Ontology (https://github.com/ingoboerner/dracor-ontology/blob/main/v1/dracor_api_ontology.ttl) The identifiers of the features (xml:id s) should allow a automatic linking to the Schemas in the OpenAPI spec (originally, including the links to the ontology, e.g. https://github.com/dracor-org/dracor-api/blob/extend_openapi/api.yaml#L1637-L1639)

At some point it should be possible to gather all <constraintSpec> elements (currently linked with @corresp to the

describing the feature) that are relevant for a feature and thus test if a TEI file in question can be processed by the API to return data on a feature.

The examples from the legacy ODD have been moved to a separate ODD file; eventually it would make sense to re-include them; an open question remains how to proceed in regards to the "Encoding Guidelines" included as a draft in the legacy ODD.

For the initial discussion see also issue #66.

@ingoboerner ingoboerner assigned cmil and unassigned cmil Jun 21, 2024
@ingoboerner ingoboerner requested a review from cmil June 21, 2024 09:13
@ingoboerner ingoboerner self-assigned this Jun 21, 2024
@ingoboerner
Copy link
Collaborator Author

ingoboerner commented Jun 25, 2024 •
edited
Loading

Do we want a warning on the edge case, e.g. pantomime:

<body>
      <div type="act">
        <stage>This is an edge case, e.g. pantomime.</stage>
      </div>
</body>

Schematron rule in <constraintSpec ident="network_check_basic_play_structure_sp"/> would warn that there are no speech acts. But I have rule <constraintSpec ident="network_play_without_speaking_characters"/> that triggers on this edge case and suggests in the case of

<body>
      <div type="act">
<!-- empty -->
      </div>
</body>

to add at least a stage direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmil cmil Awaiting requested review from cmil

Assignees

@ingoboerner ingoboerner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingoboerner @cmil