[WIP] money: Drop money on player death #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
reviewed
Feb 11, 2019
| function onPlayerHealthChange( player, lastHP, newHP ) { | ||
| if ( newHP < 0.1 && alive[player.ID]) { | ||
| alive[player.ID] = false; | ||
| local pickup = CreatePickup( 337, player.World, player.Cash * 0.8, player.Position, 255, true); |
There was a problem hiding this comment.
The original game drops a lot of pickups around dead people.
I'd like to mimic this behaviour, with a lot of cash icons around the player (10 or something).
JayFoxRox
reviewed
Feb 11, 2019
JayFoxRox
reviewed
Feb 11, 2019
scripts/module/money_drop.nut
Outdated
| } | ||
|
|
||
| function onPlayerHealthChange( player, lastHP, newHP ) { | ||
| if ( newHP < 0.1 && alive[player.ID]) { |
There was a problem hiding this comment.
Use an epsilon, which is smaller 1e-6 or something. Maybe squirrel has an epsilon defined as part of the language?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give each player $500 on spawn.
Create a pickup on death containing
player.Cash * 0.8.Should be tested before merge.
Closes #33