This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Improved dataframe handling and save declined matches also #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plitting and lookup. Also implemnent support for approved/declined in the CacheMatch and FuzzyMatch so that we now store both and act on them. crossref/enums.py: New file with enums specific to crossref models/enums.py: New file with enums fuzzy_match.py: New attribute approved match_cache.py: MatchCache: Rename private method __append_new_match_to_the_dataframe__ to __append_match_result_to_the_dataframe__ and store the new attribute in a dataframe column. __extract_match__(): Support extracting approved also. named_entity_recognition.py: Move methods to new class CrossrefSubject and rewrite __lookup_subjects__() ontology.py: Ontology: New private method __enrich_cache_match__(). Move the dataframe preparation code to __get_the_dataframe_from_config__() Handle new approved and add it to self.match. ontology_dataframe.py: Rename Dataframe to OntologyDataframe. subject.py: New file with class.
…both crossref and wikidata
…gy made from the queries.
console.py: New function print_all_matches_table() engine.py: Disable the old match table wikipedia_page.py: Print the new one
Everything is now packages.
Diagrams added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite with new CrossrefSubject class that handles all the subject splitting and lookup. Also implemnent support for approved/declined in the CacheMatch and FuzzyMatch so that we now store both and act on them.