Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont require a fork of kevinrob/guzzle-cache-middleware #2

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

dpi
Copy link
Owner

@dpi dpi commented Jul 23, 2021

as it wont work when required globally: repositories ignored for non root requirements.

…rk when required globally: repositories ignored for non root requirements.
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2 (3b2c58e) into 1.x (1550805) will decrease coverage by 0.66%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x       #2      +/-   ##
============================================
- Coverage     43.94%   43.27%   -0.67%     
- Complexity      316      323       +7     
============================================
  Files            52       53       +1     
  Lines          1106     1123      +17     
============================================
  Hits            486      486              
- Misses          620      637      +17     
Impacted Files Coverage Δ
src/Commands/Traits/HttpTrait.php 0.00% <ø> (ø)
src/Flysystem2Storage.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1550805...3b2c58e. Read the comment docs.

@dpi
Copy link
Owner Author

dpi commented Jul 23, 2021

Coverage not added as this is supposed to be short lived, and there is coverage at Kevinrob/guzzle-cache-middleware#138

@dpi dpi merged commit 959d16f into 1.x Jul 23, 2021
@dpi dpi deleted the internalise-cache-middleware branch July 23, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant