Skip to content

Commit

Permalink
Merge branch 'master' into fix/oauth-login-register-500-error
Browse files Browse the repository at this point in the history
  • Loading branch information
David Kalamarides authored Oct 4, 2023
2 parents ad8a42d + e4d613a commit e40b31a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/security.rst
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ This method will authenticate the user's credentials against an LDAP server.

WARNING: To use LDAP you need to install `python-ldap <https://www.python-ldap.org>`_.

For a typical Microsoft AD setup (where all users can preform LDAP searches)::
For a typical Microsoft AD setup (where all users can perform LDAP searches)::

AUTH_TYPE = AUTH_LDAP
AUTH_LDAP_SERVER = "ldap://ldap.example.com"
Expand Down
6 changes: 3 additions & 3 deletions flask_appbuilder/security/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ def _search_ldap(self, ldap, con, username):
if len(self.auth_roles_mapping) > 0:
request_fields.append(self.auth_ldap_group_field)

# preform the LDAP search
# perform the LDAP search
log.debug(
"LDAP search for '%s' with fields %s in scope '%s'",
filter_str,
Expand Down Expand Up @@ -1137,7 +1137,7 @@ def auth_user_ldap(self, username, password):
user_attributes = {}

# Flow 1 - (Indirect Search Bind):
# - in this flow, special bind credentials are used to preform the
# - in this flow, special bind credentials are used to perform the
# LDAP search
# - in this flow, AUTH_LDAP_SEARCH must be set
if self.auth_ldap_bind_user:
Expand Down Expand Up @@ -1173,7 +1173,7 @@ def auth_user_ldap(self, username, password):

# Flow 2 - (Direct Search Bind):
# - in this flow, the credentials provided by the end-user are used
# to preform the LDAP search
# to perform the LDAP search
# - in this flow, we only search LDAP if AUTH_LDAP_SEARCH is set
# - features like AUTH_USER_REGISTRATION & AUTH_ROLES_SYNC_AT_LOGIN
# will only work if AUTH_LDAP_SEARCH is set
Expand Down

0 comments on commit e40b31a

Please sign in to comment.